[Addon] Charlie's Application 2

[Stodgems]

In-game name: Charlie
Steam ID: STEAM_0:0:94814771
Age: 20
For how long have you played on our servers?: Recently only a month and a bit on the SCP Server but I used to play on the DarkRP back around 2016
What country are you from?: United Kingdom
Time Zone: GMT
Do you have a mic?: Yes

Is this your first application for Developer? If not, link previous ones: First

Have you received any bans?: No

How confident are you with GLua? (Rate yourself 1-10 using rating guide): 5-6

Do you have any experience with Git?:

I have continued to use git since my last application however there isn't much I have done that is different with it since my prior application, I don't feel the need to repeat what I wrote before.

Do you have previous experience as a Developer for GMod?:

I have been developer for a many GMod Servers over the years, the most recent have been a few TTT servers however I have worked on DarkRP and SWRP servers.

How many hours can you commit to developing per week?:

I can commit at least 4-5 hours a week this can change depending on how busy I am with University as I am on my last year and have my Dissertation etc. However once I finish Uni I will have more time.

Why do you want to be a Developer? What can you help us with?:

I still wish to become a developer as I have a passion for coding which lead me to learn Lua, I can help with anything that is required from me and I am ready to learn anything that the other developers will teach.

Since my first application I have worked on an idea of mine that I have had for a while which I just havent got around to starting, It is a Vampire and Vampire Hunter System which contains 2 factions, Vampires and Hunters there are shops that both factions use which contain weapons and abilities that each faction can purchase with Hunter Medallions or Vampire Hearts, these are collected from either faction killing the other. There is a Guild/Coven system included which players can join and get promoted up the ranks.

I have also included an admin menu which contains all of the different admin buttons you may want to use, such as forcing someone to be a vampire or a hunter, even adding items to the Hunter Merchant or Vampire Abilities shop.

I am still working on this so it isn't 100% complete, I am adding new features as and when I think about them.

Link

Any feedback is greatly appreciated and I will try my best to resolve any issues with the code as they are found.

Thanks for reading.

 

[KLua]

v-vh-system/lua/vampire/weapons/weapon_vampire.lua


v-vh-system/lua/vampire/weapons/weapon_vampire_claws_leap.lua


v-vh-system/lua/vampire/weapons/weapon_vampire_leap.lua


v-vh-system/lua/vampire/sv_vampire_covens.lua


v-vh-system/lua/vampire/entities/ent_vampire_abilities_trainer.lua


Comments through out the code is also Inconsistent, randomly switching between -- and //

Based on the inconsistencies in the code such as different comment styles, "Your Name" as the author and random comments above self explanatory code. It seems that this addon is largely generated by AI.

 

[Stodgems]

I have explanations for all of the mentioned above issues,

The Your Name situations with the Entities and Weapons is purely as I would just copy a blank weapon/entity file with all the SWEP/ENT table information as I found this easier that writing it out every time I was going to make a weapon/entity.

The inconsistency with the -- and // is because I did use AI just to generate the comments as I felt that having some comments was better than not having any comments.

The reasoning for having "-- ...existing code..." was because I had most if not all Coven/Guild related code in their sv files I since then had changed that and had just forgot to remove the comments relating to that so I didn't loose track as I was having some issues with the Covens/Guilds.

I have since removed the "-- ...existing code..." and I will work on ensuring that I don't use AI for the comments and will remove most if not all the pointless ones and will add some more in-depth ones.

Hope this clears up any issues.