"Businessman" dev application

["Businessman"]

In-game name: "Businessman" , "Stealthshade" , "Capital"
Steam ID: STEAM_0:1:124110588
Age: 20
For how long have you played on our servers?: since like 11/20/2021. I dont remember the exact time but
What country are you from?: Turkey
Time Zone: GMT+3
Do you have a mic?: Yes

Is this your first application for Developer? If not, link previous ones: No

Have you received any bans?: Yes i received a ban for ERP.

How confident are you with GLua? (Rate yourself 1-10 using rating guide): I guess a 6 but i have to tell few stuff about the 6. I can save data but i never used mysql i always use sv.db files to save. I can easily make a banking addon and make sure the system can't be cheated. I consider myself great with net messages.

Do you have any experience with Git?: If github yes My github: HERE

Do you have previous experience as a Developer for GMod?: I never did full on developing but i did develop just for fun and helped a friend who needed a simple addon.

How many hours can you commit to developing per week?: For this week i got finals but after this week semester is over and i mostly will be on i believe 25+ hours a week.

Why do you want to be a Developer? What can you help us with?: I want to both improve the server and also improve my skills on GLua. I believe it would be very beneficial for each side.

 

[Ogre]

+spport
cool guy

 

[Lion]

-Support

I've seen you around a bit, but I don't feel you are a good fit for our development team. The addons and code examples you provide are not enough to demonstrate you have a proficient understanding of GLua.

Here's some feedback:

• Your addons have autorun files called `cl_test.lua` and `sv_test.lua`. These files might be overridden by other addons, and it's generally accepted to have the autorun files contain names like `sh_addon_name_init.lua`.
• Your comments in `RandomTrashTalk/lua/autorun/client/cl_test.lua` are pretty self explanatory and essentially just restate what the code does. Remember comments should explain why something is done, not just restate what the code does.
• Non unique hook names ("Loading")
• Non unique net names ("TestNet")
• Uppercase autorun file in `WarTimer/WarCount/lua/autorun/War.lua`. All files in gmod addons should be snake case because linux servers like to complain about uppercase letters.
• Undescriptive variable names. (Ex: myarray in War.lua)
• In the YouAreAnIdiotVirus, it just plays a youtube video. This is problematic because YouTube won't play on 32x clients
  • We try to keep using DHTML to a minimum throughout our addons
• You remove the close button then make your own right after in the lua runner?
• Why do you not draw the entire height of the TextEntry in the lua runner? Text can still go down there afaik.
• Inconsistent variable naming (these are defined right after each other: view, isPressed, counter, FirstTime)
• You committed a comment recently that tells us how to fix an issue with your addon (according to the commit name?). Just fix the addon and commit it.

Here's some stuff we look for in developer applications:

1. Clean code
2. Namespaced network variables and hooks
3. Examples of good file structure (not just everything in autorun, keeping client and server code entirely separate)
4. Consistent variable naming
5. Bigger, more feature complete addons to demonstrate you know how to work and structure a large codebase
6. SWEPs are a good plus

I believe a 3-4 would be a more accurate and fair rating on the development scale. Civil Networks always needs developers, so it would be great if you improved your skills and became able to provide more valuable resources. If you want to prove you deserve a 6, please make the banking addon or another large scale addon to demonstrate your proficiency. I'd also recommend getting a basic understanding of MySQL (as we use it at CN for essentially everything), it's pretty similar to SQLite, which you say you can use.

 

[Otters]

-Support

You were recently unbanned from the SCP discord, not a good look for a Developer (Not even 3 weeks)

 

["Businessman"]

-Support

I've seen you around a bit, but I don't feel you are a good fit for our development team. The addons and code examples you provide are not enough to demonstrate you have a proficient understanding of GLua.

Here's some feedback:

• Your addons have autorun files called `cl_test.lua` and `sv_test.lua`. These files might be overridden by other addons, and it's generally accepted to have the autorun files contain names like `sh_addon_name_init.lua`.
• Your comments in `RandomTrashTalk/lua/autorun/client/cl_test.lua` are pretty self explanatory and essentially just restate what the code does. Remember comments should explain why something is done, not just restate what the code does.
• Non unique hook names ("Loading")
• Non unique net names ("TestNet")
• Uppercase autorun file in `WarTimer/WarCount/lua/autorun/War.lua`. All files in gmod addons should be snake case because linux servers like to complain about uppercase letters.
• Undescriptive variable names. (Ex: myarray in War.lua)
• In the YouAreAnIdiotVirus, it just plays a youtube video. This is problematic because YouTube won't play on 32x clients
  • We try to keep using DHTML to a minimum throughout our addons
• You remove the close button then make your own right after in the lua runner?
• Why do you not draw the entire height of the TextEntry in the lua runner? Text can still go down there afaik.
• Inconsistent variable naming (these are defined right after each other: view, isPressed, counter, FirstTime)
• You committed a comment recently that tells us how to fix an issue with your addon (according to the commit name?). Just fix the addon and commit it.

Here's some stuff we look for in developer applications:

1. Clean code
2. Namespaced network variables and hooks
3. Examples of good file structure (not just everything in autorun, keeping client and server code entirely separate)
4. Consistent variable naming
5. Bigger, more feature complete addons to demonstrate you know how to work and structure a large codebase
6. SWEPs are a good plus

I believe a 3-4 would be a more accurate and fair rating on the development scale. Civil Networks always needs developers, so it would be great if you improved your skills and became able to provide more valuable resources. If you want to prove you deserve a 6, please make the banking addon or another large scale addon to demonstrate your proficiency. I'd also recommend getting a basic understanding of MySQL (as we use it at CN for essentially everything), it's pretty similar to SQLite, which you say you can use.

I will try to make an addon after my exam tomorrow i can understand the concerns with my code. I normally don't write clean code or use namespaces or use a good file structures as none of these addons are really used by myself or anyone else. I just write them to improve and i just keep them but if these are problems i can write cleaner code (atleast i hope).

 

["Businessman"]

I know the UI isnt beatiful but it works as intented, can save and hold data,isnt vulnerable to net exploits. Im not sure about the cleanliness of the code i just tried whatever i can do. Link to github: HERE

 

["Businessman"]

I made this register + added a interest system to the banking system. Link to github for register: HERE

 

["Businessman"]

Made money sendable to other players updated code is available on github

 

[Alpha rest]

=support i beleve you should get a chance with the dev team but under supervision with a mentor im no lua coder as you can tell the way i decribed it but to the other reviews i think you need a little more time learning extra dev work for 2 months and comeback to apply and you could be a bril dev i reckon just some extra time on dev work then your next application i will +support

Ps sorry for my bad grammer/spelling

 

[KaptianCore]

-Support

You need more experience as a developer with more complex examples. You also need more time since you're unban.

 

[Herr Kvarkar]

Application Denied​

---

Hi @"Businessman"

Thanks for taking the time to make a programmer application.

I have chosen to deny your application as you have not demonstrated a sufficient proficiency for GLua. I suggest if you were to reapply that you do so with a greater and slightly more advanced portfolio of GLua addons so that we can better evaluate your ability to develop for Garry's Mod. If you want any examples of good projects to make, feel free to DM me.

You may re-apply in 2 weeks.​